netdev - Re: [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Aug 2011 09:14:37 +0200
From:	walter harms <wharms@....de>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Joerg Reuter <jreuter@...na.de>,
	Klaus Kudielka <klaus.kudielka@...e.org>,
	linux-hams@...r.kernel.org
Subject: Re: [PATCH 11/12] headers, scc: Add missing #include to <linux/scc.h>



Am 08.08.2011 20:20, schrieb Ben Hutchings:
> On Mon, Aug 08, 2011 at 02:24:29PM +0100, Ben Hutchings wrote:
>> <linux/scc.h> uses SIOCDEVPRIVATE, defined in <linux/sockios.h>.
>  
> Unfortunately SIOCDEVPRIVATE is also defined elsewhere by glibc,
> so including <linux/sockios.h> can result in duplicate definitions.
> So I don't think we can make this change.
> 

Maybe that is something the glibc and the kernel guys should know about.
Did someone tell them ? Is that problem documented somewhere ?

re,
 wh


> Ben.
> 
>> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
>> ---
>> This file isn't listed in MAINTAINERS but appears to be associated with
>> one of the hamradio drivers; please could one of the hams claim it?
>>
>> Ben.
>>
>>  include/linux/scc.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/scc.h b/include/linux/scc.h
>> index 3495bd9..d5916e5 100644
>> --- a/include/linux/scc.h
>> +++ b/include/linux/scc.h
>> @@ -3,6 +3,7 @@
>>  #ifndef	_SCC_H
>>  #define	_SCC_H
>>  
>> +#include <linux/sockios.h>
>>  
>>  /* selection of hardware types */
>>  
>> -- 
>> 1.7.5.4
>>
>>
>>
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html