lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Aug 2011 12:30:39 +0000 (UTC) From: WANG Cong <xiyou.wangcong@...il.com> To: netdev@...r.kernel.org Subject: Re: [PATCH net-2.6 V2] bonding:reset backup and inactive flag of slave On Tue, 16 Aug 2011 09:57:35 +0800, Weiping Pan wrote: > Eduard Sinelnikov (eduard.sinelnikov@...il.com) found that if we change > bonding mode from active backup to round robin, some slaves are still > keeping "backup", and won't transmit packets. > > As Jay Vosburgh(fubar@...ibm.com) pointed out that we can work around > that by removing the bond_is_active_slave() check, because the "backup" > flag is only meaningful for active backup mode. > > But if we just simply ignore the bond_is_active_slave() check, the > transmission will work fine, but we can't maintain the correct value of > "backup" flag for each slaves, though it is meaningless for other mode > than active backup. > > I'd like to reset "backup" and "inactive" flag in bond_open, thus we can > keep the correct value of them. > > As for bond_is_active_slave(), I'd like to prepare another patch to > handle it. > > V2: > Use C style comment. > Move read_lock(&bond->curr_slave_lock). Replace restore with reset, for > active backup mode, it means "restore", but for other modes, it means > "reset". > > Signed-off-by: Weiping Pan <panweiping3@...il.com> Reviewed-by: WANG Cong <xiyou.wangcong@...il.com> Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists