netdev - Re: [PATCH 04/14] bna: Add Multiple Tx Queue Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Aug 2011 22:48:58 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Rasesh Mody <rmody@...cade.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	adapter_linux_open_src_team@...cade.com,
	Gurunatha Karaje <gkaraje@...cade.com>
Subject: Re: [PATCH 04/14] bna: Add Multiple Tx Queue Support

On Tue, 2011-08-16 at 14:19 -0700, Rasesh Mody wrote:
> Change details:
>  - Add macros bna_prio_allow, bna_default_nw_prio, bna_iscsi_prio,
>    bna_is_iscsi_over_cee
>  - Added support for multipe Tx queues with a separate iSCSI Tx queue based
>    on the default value of iSCSI port number. The feature is supported based
>    on the underlying hardware and enabled for DCB (CEE) mode only.
>  - Allocate multiple TxQ resource in netdev
>  - Implement bnad_tx_select_queue() which enables the correct selection of
>    TxQ Id (and tcb). This function is called either by the kernel to channel
>    packets to the right TxQ
>  - bnad_tx_select_queue() returns priority, while only a few packets during
>    transition could have wrong priority, all will be associated with a valid
>    non-NULL tcb.
>  - Implement bnad_iscsi_tcb_get() and BNAD_IS_ISCSI_PKT() for iSCSI packet
>    inspection and retrieval of tcb corresponding to the iSCSI priority.
>  - Construction of priority indirection table to be used by bnad to direct
>    packets into TxQs
[...]

You probably should implement TX priority classes through the
ndo_setup_tc operation, not ndo_select_queue.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html