netdev - Re: [PATCH] bnx2x: downgrade Max BW error message to debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Aug 2011 21:51:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eilong@...adcom.com
Cc:	mschmidt@...hat.com, netdev@...r.kernel.org, dmitry@...adcom.com,
	vladz@...adcom.com
Subject: Re: [PATCH] bnx2x: downgrade Max BW error message to debug

From: "Eilon Greenstein" <eilong@...adcom.com>
Date: Thu, 18 Aug 2011 15:22:00 +0300

> On Thu, 2011-08-18 at 04:37 -0700, Michal Schmidt wrote:
>> On Wed, 17 Aug 2011 20:44:15 +0300 Eilon Greenstein wrote:
>> > I think that we should use DP instead of DBG_ERR. How about this one:
>> ... 
>> > Can you sing-off on somethign like this?
>> 
>> OK, let's use DP. Thanks!
>> 
>> 
>> Subject: [PATCH v2] bnx2x: downgrade Max BW error message to debug
>> 
>> There are valid configurations where Max BW is configured to zero for
>> some VNs.
>> Print the message only if debugging is enabled and do not call the
>> configuration "illegal".
>> 
>> [v2: use DP(), not BNX2X_DBG_ERR(); recommended by Eilon Greenstein.]
>> 
>> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> 
> Acked-by: Eilon Greenstein <eilong@...adcom.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html