lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Aug 2011 00:15:56 -0500 From: Larry Finger <Larry.Finger@...inger.net> To: Stephen Rothwell <sfr@...b.auug.org.au> CC: Greg KH <greg@...ah.com>, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, wlanfae <wlanfae@...ltek.com>, Jiri Pirko <jpirko@...hat.com>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: linux-next: build failure after merge of the staging tree On 08/25/2011 12:02 AM, Stephen Rothwell wrote: > Hi Greg, > > After merging the staging tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/staging/rtl8192e/rtl_core.c:2917:2: error: unknown field 'ndo_set_multicast_list' specified in initializer > > Caused by commit 94a799425eee ("From: wlanfae<wlanfae@...ltek.com>" - > really "[PATCH 1/8] rtl8192e: Import new version of driver from realtek" > Larry, that patch was badly imported ...) interacting with commit > b81693d9149c ("net: remove ndo_set_multicast_list callback") from the net > tree. > > I applied the following patch (which seems to be what was done to the > other drivers in the net tree - there is probably more required): > > From: Stephen Rothwell<sfr@...b.auug.org.au> > Date: Thu, 25 Aug 2011 14:57:55 +1000 > Subject: [PATCH] rtl8192e: update for ndo_set_multicast_list removal. > > Signed-off-by: Stephen Rothwell<sfr@...b.auug.org.au> > --- > drivers/staging/rtl8192e/rtl_core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl_core.c > index f8a13d9..b38f626 100644 > --- a/drivers/staging/rtl8192e/rtl_core.c > +++ b/drivers/staging/rtl8192e/rtl_core.c > @@ -2914,7 +2914,7 @@ static const struct net_device_ops rtl8192_netdev_ops = { > .ndo_stop = rtl8192_close, > .ndo_tx_timeout = rtl8192_tx_timeout, > .ndo_do_ioctl = rtl8192_ioctl, > - .ndo_set_multicast_list = r8192_set_multicast, > + .ndo_set_rx_mode = r8192_set_multicast, > .ndo_set_mac_address = r8192_set_mac_adr, > .ndo_validate_addr = eth_validate_addr, > .ndo_change_mtu = eth_change_mtu, Stephan, Thanks for the notice. It seems that commit b81693d9149c had not made it into my copy of staging. I'll look into the issue. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists