netdev - Re: [PATCH] mii: Remove references to DP83840 PHY in mii.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Sep 2011 10:22:47 +0100
From:	Mark Einon <mark.einon@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] mii: Remove references to DP83840 PHY in mii.h

On 31 August 2011 18:34, Ben Hutchings <bhutchings@...arflare.com> wrote:
>
> Since you're trying to improve these comments, I think this could do
> with further improvement.  When this bit is set, the PHY's data paths
> are isolated from the MII (or other interface to the MAC).  The control
> path is still connected to the management interface (MDIO), which is
> important when we want to clear this bit!  So it would be better to say
> something like 'Isolate data paths fromn MII'.

>
> This selects a low-power state (if implemented).  It doesn't entirely
> turn the PHY off, and at least the management interface must stil be
> functional.  So it would be better to say 'Request low-power state'.

Hi Ben,

Fair points, hope I've addressed these in the revised patch.

> This formatting change is unrelated.  If you're going to fix formatting
> then please convert spaces to tabs after each name and value.
>

Done, and broken out into a separate patch.

Cheers,

Mark
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html