netdev - Re: [PATCH net 6/6] bnx2x: Fix ethtool advertisement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 7 Sep 2011 12:39:03 +0300
From:	"Yaniv Rosner" <yanivr@...adcom.com>
To:	"Ben Hutchings" <bhutchings@...arflare.com>
cc:	"Yaniv Rosner" <yaniv.rosner@...adcom.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Eilon Greenstein" <eilong@...adcom.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net 6/6] bnx2x: Fix ethtool advertisement

On Tue, 2011-09-06 at 08:19 -0700, Ben Hutchings wrote:
> On Tue, 2011-09-06 at 09:47 +0300, Yaniv Rosner wrote:
> > Enable changing advertisement settings via ethtool and fix
> > flow-control advertisement when autoneg flow-control is disabled.
> [...]
> > diff --git a/drivers/net/bnx2x/bnx2x_main.c b/drivers/net/bnx2x/bnx2x_main.c
> > index f74582a..42c7be1 100644
> > --- a/drivers/net/bnx2x/bnx2x_main.c
> > +++ b/drivers/net/bnx2x/bnx2x_main.c
> > @@ -2125,6 +2125,12 @@ static int bnx2x_set_spio(struct bnx2x *bp, int spio_num, u32 mode)
> >  void bnx2x_calc_fc_adv(struct bnx2x *bp)
> >  {
> >  	u8 cfg_idx = bnx2x_get_link_cfg_idx(bp);
> > +	if (bp->link_params.req_flow_ctrl[cfg_idx] != BNX2X_FLOW_CTRL_AUTO) {
> > +		bp->port.advertising[cfg_idx] &= ~(ADVERTISED_Asym_Pause |
> > +						   ADVERTISED_Pause);
> > +		return;
> > +	}
> [...]
> 
> I think you should still advertise the flow control behaviour you want,
> even if you will override the result of autonegotiation.
> 
> Ben.
> 
Ben,
It's a gray area, so I don't have a strong opinion this way or another.
I trust your senses, and will follow your suggestion to fix it.
Thanks,
Yaniv


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html