lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Sep 2011 18:26:33 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Eric Dumazet <eric.dumazet@...il.com> Cc: Markus Trippelsdorf <markus@...ppelsdorf.de>, David Miller <davem@...emloft.net>, akpm@...ux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [GIT] Networking On Sun, Sep 18, 2011 at 1:35 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > > [PATCH] tcp: fix build error if !CONFIG_SYN_COOKIE > > commit 946cedccbd7387 (tcp: Change possible SYN flooding messages) > added a build error if CONFIG_SYN_COOKIE=n Christ Eric, you clearly didn't even compile-test this one either. Which is pretty bad, considering that the whole and only *point* of the patch is to make it compile. The config option is CONFIG_SYN_COOKIES (with an 'S' at the end), but your patch has 'CONFIG_SYN_COOKIE' (without the S). Which means that now it doesn't compile when syncookies are *enabled*. I really wanted to release -rc7 today. But no way am I applying these kinds of totally untested patches. Can you guys please get your act together? PLEASE? Stop with the "this might just work" crap. Because -rc7 is just too late to dick around like that. Linus -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists