| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Sep 2011 21:21:58 +1000 From: Herbert Xu <herbert@...dor.apana.org.au> To: Steffen Klassert <steffen.klassert@...unet.com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] xfrm: Perform a replay check after return from async codepaths On Wed, Sep 21, 2011 at 11:38:58AM +0200, Steffen Klassert wrote: > When asyncronous crypto algorithms are used, there might be many > packets that passed the xfrm replay check, but the replay advance > function is not called yet for these packets. So the replay check > function would accept a replay of all of these packets. Also the > system might crash if there are more packets in async processing > than the size of the anti replay window, because the replay advance > function would try to update the replay window beyond the bounds. > > This pach adds a second replay check after resuming from the async > processing to fix these issues. > > Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com> Actually why does this matter? For a single SA, the processing in xfrm_input should be completely synchronous, even when you're using asynchronous algorithms. Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists