lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 23 Sep 2011 12:43:26 -0400 From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: "Rose, Gregory V" <gregory.v.rose@...el.com>, Ian Campbell <ijc@...lion.org.uk>, "davem@...emloft.net" <davem@...emloft.net>, Jesse Barnes <jbarnes@...tuousgeek.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "gospo@...hat.com" <gospo@...hat.com>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org> Subject: Re: [net-next 1/8] pci: Add flag indicating device has been assigned by KVM On Fri, Sep 23, 2011 at 08:45:09AM -0700, Jeff Kirsher wrote: > On Fri, 2011-09-23 at 08:11 -0700, Rose, Gregory V wrote: > > > -----Original Message----- > > > From: Ian Campbell [mailto:ijc@...lion.org.uk] > > > Sent: Friday, September 23, 2011 8:04 AM > > > To: Rose, Gregory V > > > Cc: Kirsher, Jeffrey T; davem@...emloft.net; konrad.wilk@...cle.com; Jesse > > > Barnes; netdev@...r.kernel.org; gospo@...hat.com; linux- > > > pci@...r.kernel.org > > > Subject: RE: [net-next 1/8] pci: Add flag indicating device has been > > > assigned by KVM > > > > > > On Fri, 2011-09-23 at 07:41 -0700, Rose, Gregory V wrote: > > > > > -----Original Message----- > > > > > From: Ian Campbell [mailto:ijc@...lion.org.uk] > > > > > Sent: Friday, September 23, 2011 12:28 AM > > > > > To: Kirsher, Jeffrey T > > > > > Cc: davem@...emloft.net; konrad.wilk@...cle.com; Jesse Barnes; Rose, > > > > > Gregory V; netdev@...r.kernel.org; gospo@...hat.com; linux- > > > > > pci@...r.kernel.org > > > > > Subject: Re: [net-next 1/8] pci: Add flag indicating device has been > > > > > assigned by KVM > > > > > > > > > > I suppose by that measure the comment could be less KVM specific: > > > > > > + /* Provide indication device is assigned by KVM */ > > > > > > + PCI_DEV_FLAGS_ASSIGNED = (__force pci_dev_flags_t) 4, > > > > > > > > We can resubmit with a more generic comment, maybe this: > > > > > > > > /* Provide indication device is assigned by a Virtual Machine Manager */ > > > > > > Sounds good to me. > > > > Dave, Jeff, > > > > Should I resubmit the patch or would it be more convenient to post a follow on patch that fixes up the comment? Either way is fine by me. > > > > - Greg > > > > let's fix up the patch in my tree and add Jesse Barnes's ACK at the same > time. Were are the patches now? I am kind of curious to see the changes to the xen pciback. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists