netdev - Re: [net-next 01/02] ixgb: eliminate checkstack warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Sep 2011 13:56:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	jesse.brandeburg@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com
Subject: Re: [net-next 01/02] ixgb: eliminate checkstack warnings

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 23 Sep 2011 05:11:29 -0700

> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> Really trivial fix, use kmalloc/kfree instead of stack space.
> use static const instead of const to further reduce stack usage.
> 
> V2: reflect changes suggested by Joe Perches
> 
> before:
> [jbrandeb@...andeb-mobl2 linux-2.6]$ make checkstack|grep '\[ixgb\]'
> 0x00000fc1 ixgb_set_multi [ixgb]:                       768
> 0x00001031 ixgb_set_multi [ixgb]:                       768
> 0x000010f2 ixgb_set_multi [ixgb]:                       768
> 0x061c ixgb_check_options [ixgb]:                       448
> 0x09c3 ixgb_check_options [ixgb]:                       448
> 0x0000649e ixgb_set_ringparam [ixgb]:                   192
> 0x0000130d ixgb_xmit_frame [ixgb]:                      184
> 0x000019e0 ixgb_xmit_frame [ixgb]:                      184
> 0x00002267 ixgb_clean [ixgb]:                           152
> 0x00002673 ixgb_clean [ixgb]:                           152
> 
> after:
> 0x000064ee ixgb_set_ringparam [ixgb]:                   192
> 0x0000135d ixgb_xmit_frame [ixgb]:                      184
> 0x00001a30 ixgb_xmit_frame [ixgb]:                      184
> 0x000022b7 ixgb_clean [ixgb]:                           152
> 0x000026c3 ixgb_clean [ixgb]:                           152
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html