netdev - RE: [RFC/PATCH] net: add deferred flow cache flush function to be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 26 Sep 2011 19:58:54 +0300
From:	Madalin Bucur <madalin.bucur@...escale.com>
To:	<eric.dumazet@...il.com>
CC:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<timo.teras@....fi>, Madalin Bucur <madalin.bucur@...escale.com>
Subject: RE: [RFC/PATCH] net: add deferred flow cache flush function to be

I've investigated this issue further and come up with a different fix -
modify the flow_cache_flush to prevent it from sleeping and also remove the
deferral of the actual gc work through schedule_work. That caused the gc never
to happen on a highly loaded system that had the cpus occupied servicing
network softirqs.

During the investigation I've also found two places the return value of 
dst_alloc was used without checking, leading to a crash. 

The 3 patches will follow.

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On 
> Behalf Of Eric Dumazet
>
> Problem is sometime we dont want to defer and are in process context.
> 
> xfrm_dev_event(  event == NETDEV_DOWN) is probably a place we dont want
> to defer the garbage collection.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html