netdev - Re: [net-next 1/7] bna: Brocade 1860 IOC PLL, Reg Defs and ASIC Mode Changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Sep 2011 16:26:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rasesh Mody <rmody@...cade.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	adapter_linux_open_src_team@...cade.com,
	Gurunatha Karaje <gkaraje@...cade.com>
Subject: Re: [net-next 1/7] bna: Brocade 1860 IOC PLL, Reg Defs and ASIC
 Mode Changes

On Tue, 2011-09-27 at 13:39 -0700, Rasesh Mody wrote:
> Add logic to set ASIC specfic interface in IOC, HW interface initialization
> APIs, mode based initialization and MSI-X resource allocation for 1860 with
> no asic block. Add new h/w specific register definitions and setup registers
> used by IOC logic.

decidedly trivial...

> diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
[]
> @@ -1981,7 +1981,13 @@ bfa_nw_ioc_pci_init(struct bfa_ioc *ioc, struct bfa_pcidev *pcidev,
>  		BUG_ON(1);
>  	}
>  
> -	bfa_nw_ioc_set_ct_hwif(ioc);
> +	/**
> +	 * Set asic specific interfaces.
> +	 */
> +	if (ioc->asic_gen == BFI_ASIC_GEN_CT)
> +		bfa_nw_ioc_set_ct_hwif(ioc);
> +	else
> +		bfa_nw_ioc_set_ct2_hwif(ioc);
[]
> diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c b/drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c
[]
>  	/**
>  	 * sram memory access
>  	 */

> @@ -256,6 +310,64 @@ bfa_ioc_ct_reg_init(struct bfa_ioc *ioc)
[]
> +	/**
> +	 * sram memory access
> +	 */

There's at least a few places where this introductory /**
comment style is used.  Perhaps this confuses kernel-doc.
I think that it should just be /*


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html