netdev - Re: [PATCH net-next] tcp: unalias tcp_skb_cb flags and ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 27 Sep 2011 10:01:46 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	christoph.paasch@...ouvain.be
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	hkchu@...gle.com, ilpo.jarvinen@...sinki.fi, jhs@...atatu.com
Subject: Re: [PATCH net-next] tcp: unalias tcp_skb_cb flags and ip_dsfield

Le mardi 27 septembre 2011 à 10:37 +0300, Christoph Paasch a écrit :
> Hi,
> 
> I realize that before "struct tcp_skb_cb" is a comment saying that it's 44 
> bytes long.
> 
> However, (as far as I can see) before Eric's change it was 42 bytes long and 
> now it became 43 bytes.
> 
> Wouldn't it make sense to change the comment, so that it's consistent again 
> with the real size of tcp_skb_cb ?

You are mistaken :)

There was a two bytes hole.

I took one byte for dsfield, and left one byte hole,

I added a comment to remind there is this hole

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html