| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 1 Oct 2011 04:36:53 +0900 From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com> To: David Miller <davem@...emloft.net> Cc: yoshihiro.shimoda.uh@...esas.com, sfr@...b.auug.org.au, netdev@...r.kernel.org, linux-sh@...r.kernel.org Subject: Re: [PATCH] net: sh_eth: fix build failure I see. Thanks you. Nobuhiro 2011/9/30 David Miller <davem@...emloft.net>: > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> > Date: Fri, 30 Sep 2011 16:51:34 +0900 > >> 2011/09/30 15:55, Nobuhiro Iwamatsu wrote: >>> 2011/9/30 Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>: >> < snip > >>>> +#include <linux/kernel.h> >>>> +#include <linux/spinlock.h> >>> These are not required. >> >> The Documentation/SubmitChecklist says the following: >> >> ======================================================== >> 1: If you use a facility then #include the file that defines/declares >> that facility. Don't depend on other header files pulling in ones >> that you use. >> ======================================================== >> >> The sh_eth driver uses spinlock functions and some macros of kernel.h. >> So, I think that I have to write their "#include" in the driver. > > Agreed. > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Nobuhiro Iwamatsu -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists