netdev - Re: [PATCH 1/8] vxge: convert to SKB paged frag API.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 05 Oct 2011 17:32:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mirqus@...il.com
Cc:	ian.campbell@...rix.com, netdev@...r.kernel.org, jdmason@...zu.us
Subject: Re: [PATCH 1/8] vxge: convert to SKB paged frag API.

From: Michał Mirosław <mirqus@...il.com>
Date: Wed, 5 Oct 2011 23:03:27 +0200

> 2011/10/5 Ian Campbell <ian.campbell@...rix.com>:
> [...]
>> --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c
>> +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c
>> @@ -923,9 +923,9 @@ vxge_xmit(struct sk_buff *skb, struct net_device *dev)
>>                if (!frag->size)
>>                        continue;
>>
>> -               dma_pointer = (u64) pci_map_page(fifo->pdev, frag->page,
>> -                               frag->page_offset, frag->size,
>> -                               PCI_DMA_TODEVICE);
>> +               dma_pointer = (u64)skb_frag_dma_map(&fifo->pdev->dev, frag,
>> +                                                   0, frag->size,
>> +                                                   PCI_DMA_TODEVICE);
> 
> This should be DMA_TO_DEVICE instead of PCI_DMA_TODEVICE.
> 
>>
>>                if (unlikely(pci_dma_mapping_error(fifo->pdev, dma_pointer)))
>>                        goto _exit2;
> 
> I would also change this to dma_mapping_error() in one go.
> 
> Just a random patch check.

I'll make these adjustments when I apply this patch, thanks.