netdev - Re: xfrm warning by mip6d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Oct 2011 15:32:43 +0200
From:	András Takács <linux-kernel@...oond.hu>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: xfrm warning by mip6d

Thanks for the help. I added this two skb_dst_force calls to my kernel source, but unfortunately it didn't solved the problem.

I know it's just a warning message, but I would be happy, if I could fix it.

Does anybody have any other idea?


Thank you very much!

Regards,
András Takács
http://www.wakoond.hu

On 2011.10.05., at 12:33, Eric Dumazet wrote:

> Le mercredi 05 octobre 2011 à 11:22 +0200, András Takács a écrit :
> 
> Issue solved by commit 3bc07321ccc236f693ce1b6a8786f0a2e38bb87e
> 
> Thanks
> 
> 
> commit 3bc07321ccc236f693ce1b6a8786f0a2e38bb87e
> Author: Steffen Klassert <steffen.klassert@...unet.com>
> Date:   Tue Mar 15 21:08:28 2011 +0000
> 
>    xfrm: Force a dst refcount before entering the xfrm type handlers
> 
>    Crypto requests might return asynchronous. In this case we leave
>    the rcu protected region, so force a refcount on the skb's
>    destination entry before we enter the xfrm type input/output
>    handlers.
> 
>    This fixes a crash when a route is deleted whilst sending IPsec
>    data that is transformed by an asynchronous algorithm.
> 
>    Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
>    Signed-off-by: David S. Miller <davem@...emloft.net>
> 
> diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
> index 872065c..341cd11 100644
> --- a/net/xfrm/xfrm_input.c
> +++ b/net/xfrm/xfrm_input.c
> @@ -190,6 +190,8 @@ int xfrm_input(struct sk_buff *skb, int nexthdr, __be32 spi, int encap_type)
> 		XFRM_SKB_CB(skb)->seq.input.low = seq;
> 		XFRM_SKB_CB(skb)->seq.input.hi = seq_hi;
> 
> +		skb_dst_force(skb);
> +
> 		nexthdr = x->type->input(x, skb);
> 
> 		if (nexthdr == -EINPROGRESS)
> diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c
> index 1aba03f..8f3f0ee 100644
> --- a/net/xfrm/xfrm_output.c
> +++ b/net/xfrm/xfrm_output.c
> @@ -78,6 +78,8 @@ static int xfrm_output_one(struct sk_buff *skb, int err)
> 
> 		spin_unlock_bh(&x->lock);
> 
> +		skb_dst_force(skb);
> +
> 		err = x->type->output(x, skb);
> 		if (err == -EINPROGRESS)
> 			goto out_exit;
> 
> 
> 



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html