[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 10 Oct 2011 14:10:53 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: cascardo@...ux.vnet.ibm.com
Cc: netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
eli@....mellanox.co.il, yevgenyp@...lanox.co.il,
benh@...nel.crashing.org
Subject: Re: [PATCH] mlx4_en: fix endianness with blue frame support
From: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
Date: Mon, 10 Oct 2011 13:46:54 -0300
> On Mon, Oct 10, 2011 at 01:42:23PM -0300, Thadeu Lima de Souza Cascardo wrote:
>> The doorbell register was being unconditionally swapped. In x86, that
>> meant it was being swapped to BE and written to the descriptor and to
>> memory, depending on the case of blue frame support or writing to
>> doorbell register. On PPC, this meant it was being swapped to LE and
>> then swapped back to BE while writing to the register. But in the blue
>> frame case, it was being written as LE to the descriptor.
>>
>> The fix is not to swap doorbell unconditionally, write it to the
>> register as BE and convert it to BE when writing it to the descriptor.
>>
>> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...ux.vnet.ibm.com>
>> Reported-by: Richard Hendrickson <richhend@...ibm.com>
>> Cc: Eli Cohen <eli@....mellanox.co.il>
>> Cc: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
>> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> ---
>
> So I tested this patch and it works for me. Thanks Ben and Eli for
> finding out the problem with doorbell in the descriptor.
Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists