lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Oct 2011 10:06:48 +0800 From: WeipingPan <panweiping3@...il.com> To: herbert@...dor.hengli.com.au CC: "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org> Subject: Re: [PATCH net] vlan:make mtu of vlan equal to physical dev Hi, Herbert, What do you think of this patch ? thanks Weiping Pan On 10/08/2011 06:12 PM, Weiping Pan wrote: > Default mtu of vlan device is the same with mtu of physical device, > for example 1500, but when change physics mtu to 1600, > VLAN device's mtu is still 1500. > Certainly, you can change vlan device's mtu to 1600 manually, > but I think when you change physics device's mtu, VLAN's mtu should be changed > automatically instead of by manually. > > Steps to Reproduce: > 1.vconfig add eth4 3 > 2.ifconfig eth4 mtu 1600 > 3.check mtu on eth4.3 > > And what's worse is that if you decrease mtu of pyhsical device, > and when you want to increase it, the mtu of vlan device won't be changed. > > Steps to Reproduce: > 1.vconfig add eth4 3 > 2.ifconfig eth4 mtu 100 > 3.ifconfig eth4 mtu 1500 > 4.the mtu of eth4.3 is still 100 > > This bug is reported by Liang Zheng(lzheng@...hat.com). > > Signed-off-by: Weiping Pan<panweiping3@...il.com> > --- > net/8021q/vlan.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index 8970ba1..f6072b4 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -417,9 +417,6 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event, > if (!vlandev) > continue; > > - if (vlandev->mtu<= dev->mtu) > - continue; > - > dev_set_mtu(vlandev, dev->mtu); > } > break; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists