| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Oct 2011 19:22:36 +0200 From: Michał Mirosław <mirqus@...il.com> To: Jiri Pirko <jpirko@...hat.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, eric.dumazet@...il.com, bhutchings@...arflare.com, shemminger@...tta.com, fubar@...ibm.com, andy@...yhouse.net, tgraf@...radead.org, ebiederm@...ssion.com, kaber@...sh.net, greearb@...delatech.com, jesse@...ira.com, fbl@...hat.com, benjamin.poirier@...il.com, jzupka@...hat.com Subject: Re: [patch net-next V4] net: introduce ethernet teaming device 2011/10/24 Jiri Pirko <jpirko@...hat.com>: > This patch introduces new network device called team. It supposes to be > very fast, simple, userspace-driven alternative to existing bonding > driver. [...] > drivers/net/team/team.c | 1573 +++++++++++++++++++++++++++++ > drivers/net/team/team_mode_activebackup.c | 152 +++ > drivers/net/team/team_mode_roundrobin.c | 107 ++ I think this mode-modularity is overkill. One mode will compile to at most a few hundred bytes of code+data, but will use at least 10 times that to get loaded and tracked properly. How often/how many more modes you anticipate to be introduced? You could just keep the modular design but drop the kernel module separation and maybe have modes conditionally compiled (for those from the embedded world squeezing every byte). Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists