[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 29 Oct 2011 09:55:29 +0200
From: Michał Mirosław <mirqus@...il.com>
To: John <linux@...2.net>
Cc: netdev@...r.kernel.org, andy@...yhouse.net
Subject: Re: [PATCH 1/2] bonding: Doesn't support IPv6
2011/10/29 John <linux@...2.net>:
> --- a/drivers/net/bonding/bond_main.c 2011-04-19 11:18:48.000000000 -0700
> +++ b/drivers/net/bonding/bond_main.c 2011-10-27 11:26:20.000000000 -0700
[...]
> + v6hash = (v6hash >> 16) ^ (v6hash >> 8) ^ v6hash;
This XORs in only 3 of 4 bytes, and assuming count > 256 (its unlikely
you have more than 256 slaves in bond) the most significant byte is
wasted. It should be:
v6hash ^= v6hash >> 16;
v6hash ^= v6hash >> 8;
Same for IPv4 part.
OTOH, if that was your intention, then the description in your mail was wrong.
Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists