lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Nov 2011 05:06:36 -0400 (EDT) From: David Miller <davem@...emloft.net> To: roy.qing.li@...il.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH next-net] ipv6: Use hlist_for_each_entry_rcu_bh() in ipv6_chk_same_addr() From: RongQing Li <roy.qing.li@...il.com> Date: Tue, 1 Nov 2011 17:05:19 +0800 > 2011/11/1 David Miller <davem@...emloft.net>: >> From: RongQing Li <roy.qing.li@...il.com> >> Date: Tue, 1 Nov 2011 16:33:49 +0800 >> >>> Yes, But I think the code readable is not good, >> >> It is wasteful to add multiple BH disables and RCU memory >> barriers in code paths where it is not necessary. >> >> Your patch fixes no real bug, and adds a regression. >> > > hlist_for_each_entry_rcu_bh() does not disable BH, > it only check If BH is disabled. > > These codes is different from normal RCU convention. But adding _rcu does add memory barriers. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists