lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 04 Nov 2011 17:48:33 -0400 (EDT) From: David Miller <davem@...emloft.net> To: johannes@...solutions.net Cc: netdev@...r.kernel.org, tgraf@...g.ch Subject: Re: [PATCH] netlink: validate NLA_MSECS length From: Johannes Berg <johannes@...solutions.net> Date: Thu, 03 Nov 2011 11:07:32 +0100 > From: Johannes Berg <johannes.berg@...el.com> > > L2TP for example uses NLA_MSECS like this: > policy: > [L2TP_ATTR_RECV_TIMEOUT] = { .type = NLA_MSECS, }, > code: > if (info->attrs[L2TP_ATTR_RECV_TIMEOUT]) > cfg.reorder_timeout = nla_get_msecs(info->attrs[L2TP_ATTR_RECV_TIMEOUT]); > > As nla_get_msecs() is essentially nla_get_u64() plus the > conversion to a HZ-based value, this will not properly > reject attributes from userspace that aren't long enough > and might overrun the message. > > Add NLA_MSECS to the attribute minlen array to check the > size properly. > > Cc: Thomas Graf <tgraf@...g.ch> > Cc: stable@...r.kernel.org > Signed-off-by: Johannes Berg <johannes.berg@...el.com> Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists