netdev - Re: [PATCH Kernel-3.1.0] mdio-gpio: Add reset functionality to mdio-gpio driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Nov 2011 12:07:36 +0000
From:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, stuart.menefy@...com
Subject: Re: [PATCH Kernel-3.1.0] mdio-gpio: Add reset functionality to mdio-gpio
 driver.

Hi Dave,
Thanks for the comments,

David Miller wrote:
> From: Srinivas KANDAGATLA <srinivas.kandagatla@...com>
> Date: Wed,  9 Nov 2011 13:38:51 +0000
>
>> +	mdio_gpio_ops.reset = pdata->reset;
>
> What if I have multiple types of devices backing a mdio_gpio, each using
> different reset operations?
>
> You can't write this variable method into a globally used set of ops.
I agree with your comment.
Here is the modified patch, which moves the reset function pointer to
mdiobb_ctrl struct.

Thanks
srini

View attachment "0001-mdio-gpio-Add-reset-functionality-to-mdio-gpio-drive.patch" of type "text/x-patch" (2919 bytes)