netdev - RE: [PATCH 2/2 v4] net/smsc911x: Add regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Nov 2011 13:59:41 +0100
From:	Robert MARKLUND <robert.marklund@...ricsson.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Steve Glendinning <steve.glendinning@...c.com>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Tony Lindgren <tony@...mide.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"uclinux-dist-devel@...ckfin.uclinux.org" 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: RE: [PATCH 2/2 v4] net/smsc911x: Add regulator support


> -----Original Message-----
> From: Mike Frysinger [mailto:vapier@...too.org]
> Sent: den 31 oktober 2011 19:21
> To: Robert MARKLUND
> Cc: netdev@...r.kernel.org; Steve Glendinning; Mathieu Poirier; Paul Mundt; linux-sh@...r.kernel.org;
> Sascha Hauer; Tony Lindgren; linux-omap@...r.kernel.org; uclinux-dist-devel@...ckfin.uclinux.org;
> Linus Walleij
> Subject: Re: [PATCH 2/2 v4] net/smsc911x: Add regulator support
> 
> On Monday 31 October 2011 08:38:39 Robert Marklund wrote:
> > ChangeLog v3->v4:
> > - Remove dual prints and old comment on Mike's request.
> > - Split the request_free fucntion on Mike and Sascha request.
> 
> would be nice if the enable/disable were split as well ...

I interpret this as "nice if", if it's a "must be" then ill change it.

> 
> >  	iounmap(pdata->ioaddr);
> >
> > +	(void)smsc911x_enable_disable_resources(pdev, false);
> 
> i don't think the (void) cast is necessary

I like telling the reader of the code that I ignore the return value, 
I did not just forget it.

/R

> 
> otherwise looks fine
> -mike