lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Nov 2011 09:11:56 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Junchang Wang <junchangwang@...il.com> Cc: Stephen Hemminger <stephen.hemminger@...tta.com>, netdev@...r.kernel.org, romieu@...zoreil.com, nic swsd <nic_swsd@...ltek.com> Subject: Re: [PATCH net-next] r8169: Add 64bit statistics Le jeudi 17 novembre 2011 à 15:46 +0800, Junchang Wang a écrit : > > You dont need per-cpu since Tx is locked by dev->xmit_lock and > > rx is implicitly single threaded by NAPI. > > Thanks. > > >You do need to have > > two u64_stat_sync entries (one for Tx and one for Rx). > > You mean Rx and Tx will perform on different cores at one moment. > So I need a sync for Tx to protect tx_xxx, and another for Rx to > protect rx_xxx. Is that right? > Yes, look at sky2.c for a template drivers/net/ethernet/marvell/sky2.c contains code like that (different syncp for rx/tx) TX path: u64_stats_update_begin(&sky2->tx_stats.syncp); ++sky2->tx_stats.packets; sky2->tx_stats.bytes += skb->len; u64_stats_update_end(&sky2->tx_stats.syncp); RX path: u64_stats_update_begin(&sky2->rx_stats.syncp); sky2->rx_stats.packets += packets; sky2->rx_stats.bytes += bytes; u64_stats_update_end(&sky2->rx_stats.syncp); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists