lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Nov 2011 15:36:02 +0100 From: Sjur BRENDELAND <sjur.brandeland@...ricsson.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: "David S. Miller" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org> Subject: RE: [patch] caif: fix endian conversion in cffrml_transmit() Hi Dan, > The "tmp" variable here is used to store the result of cpu_to_le16() > so it should be a u16 instead of an int. We want the high bits set > and the current code works on little endian systems but not on big > endian systems. > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Looks OK by me, unless you want to make sparse with __CHECK_ENDIAN__ shut up, then you should use __le16 ;-) Acked-by: Sjur Brændeland <sjur.brandeland@...ricsson.com> Regards, Sjur -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists