netdev - Re: MPLS for Linux kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Nov 2011 16:51:55 +0100
From:	Igor Maravić <igorm@....rs>
To:	jorge@...2.net
Cc:	netdev@...r.kernel.org
Subject: Re: MPLS for Linux kernel

>        But you failed to provide patches, that fix ONE thing at a time, and not a
> patch with all the work that you have done, that's what you sent me for the
> stack overflow bug or have done now with the git tree. Providing clean,
> separated patches it's YOUR work if you WANT to see them applied on the
> mpls-linux tree.
>

It will do that when I have free time.

>        You have #ifdefed the MPLS code in the core networking code, that's wrong,
> that's not the way to go if you want to see the code merged upstream. The shim
> layer was thought as a core component of the kernel. If we rip it what we come
> at with should be #ifdef-less.
>

If the kernel is compiled witout CONFIG_IP_MPLS we would have intact
core networking code.
That was my idea. Why we would need that code if we don't use MPLS?


>>>        The other thing that probably I am going to remove is the labelspace support. I
>>> don't see a use for it, and even Cisco doesn't implement it either that I know.
>>
>> That's 15 min of work, but I think that labelspaces should stay.
>
>        Yes, I dit it an hour ago on a private branch. :) Why should did it stay?

Because of RFCs.

>        Yes, I did not finish the change code because no ones uses it currently
> (iproute, quagga). In my opinion the instructions should be nested attributes,
> and we have to change how the MPLS_CHANGE_* flags get passed, currently it's a hack.
>

I like it this way. Don't see the problem with that part of the code.
BR
Igor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html