netdev - Re: [PATCH v3 01/10] dql: Dynamic queue limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Nov 2011 16:05:50 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v3 01/10] dql: Dynamic queue limits

Le mercredi 23 novembre 2011 à 15:58 +0100, Eric Dumazet a écrit :

> Another question is : Is DQL planned to work on 32bit arch ?
> 
> A fast interface can probably send more than 2^32 bytes for large
> slack_hold_time values, and wrap around.
> 
> If yes : We can use "unsigned int" instead of "unsigned long" to lower
> memory need on 64bit arch.
> 
> If no, "unsigned long" type is not enough on 32bit, or we need to limit
> slack_hold_time to small intervals...
> 
> 

Hmm, reading again the code, 32bit counters should be more than enough,
instead of "unsigned long", on all arches.

unsigned long is only needed for slack_start_time  (to store jiffies)

This would lower sizeof( struct dql) to 48 or 56 bytes.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html