netdev - Re: [NET][TG3] Fwd: page allocation failure with linux 3.1.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Nov 2011 09:26:02 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Пламен Петров 
	<plamen.sisi@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [NET][TG3] Fwd: page allocation failure with linux 3.1.1

Le lundi 28 novembre 2011 à 09:16 +0200, Пламен Петров a écrit :

> Well, Eric, thanks for the explanation! I will disable TSO and will
> see how is that working out for me - if I recall correctly, I had no
> problems when TSO was off.
> 
> Sorry to bother you, if the above explanation was somewhere readily
> available, but I didn't manage to find it.

You dont bother me at all :)

As a matter of fact, your mail reminded me something I wanted to do in
the past and forgot about.

Since some devices might copy skb to a linear one in their
ndo_start_xmit(), we could set a netdev limit so that TSO can still be
used on these devices, but limiting number of frags to
2^PAGE_ALLOC_COSTLY_ORDER

(Since PAGE_ALLOC_COSTLY_ORDER == 3, thats 8 frags, instead of 16 right
now on x86)

Of course, if memory is really tight, even an ATOMIC order-3 allocation
might fail. If this happens, device limit could be dynamically
decreased. In the end, only linear skb could be built by TCP.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html