netdev - Re: [ovs-dev] [PATCH] datapath: Fix build breakage on kernel 2.6.40

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Dec 2011 15:38:24 -0800
From:	Jesse Gross <jesse@...ira.com>
To:	Zhi Yong Wu <zwu.kernel@...il.com>
Cc:	dev@...nvswitch.org, netdev@...r.kernel.org, aliguori@...ibm.com,
	stefanha@...il.com
Subject: Re: [ovs-dev] [PATCH] datapath: Fix build breakage on kernel 2.6.40

On Thu, Dec 1, 2011 at 6:25 PM, Zhi Yong Wu <zwu.kernel@...il.com> wrote:
> On Thu, Dec 1, 2011 at 5:55 AM, Jesse Gross <jesse@...ira.com> wrote:
>> On Wed, Nov 23, 2011 at 1:58 AM, Zhi Yong Wu <zwu.kernel@...il.com> wrote:
>>> diff --git a/datapath/linux/compat/include/linux/skbuff.h b/datapath/linux/compat/include/linux/skbuff.h
>>> index 311bfdb..22ba2e6 100644
>>> --- a/datapath/linux/compat/include/linux/skbuff.h
>>> +++ b/datapath/linux/compat/include/linux/skbuff.h
>>> @@ -239,7 +239,7 @@ static inline struct page *skb_frag_page(const skb_frag_t *frag)
>>>  }
>>>  #endif
>>>
>>> -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,0,0)
>>> +#ifndef HAVE_SKB_RESET_MAC_LEN
>>
>> 2.6.40 is the early name for 3.0.  Does it work if you just replace
>> the check with KERNEL_VERSION(2,6,40)?
> Yeah, it can work now, but i don't know if this issue exist on other
> old kernel version < 2.6.40.

Usually we just do these types of checks as we see examples of actual
backporting to avoid having hundreds of tests at configure time.  In
this case, I think the issue is just a difference in how the same
kernel is numbered not backporting, so there isn't really a reason to
believe that this is a bigger problem.

> Should we send one updated patch for this based on your suggestion?

That would be great, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html