netdev - Re: [PATCH net-next] r8169: Support for byte queue limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 03 Dec 2011 07:48:11 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	igorm@....rs
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Tom Herbert <therbert@...gle.com>
Subject: Re: [PATCH net-next] r8169: Support for byte queue limits

Le vendredi 02 décembre 2011 à 22:54 +0100, Igor Maravić a écrit :
> >
> > Reread what I said : "BQL must be lightweight"
> >
> > Not : "No lock should be used"
> >
> > OK ?
> >
> 
> I'm out of ideas.
> 
> Do you think, if I remove netdev_reset_queue(tp->dev); from
> rtl8169_init_ring_indexes,
> and spin_locks, of course, that would be a good solution.
> 
> As far as I could see in marvell/sky2.c,  sfc/tx.c and intel/e1000e/netdev.c
> netdev_completed is called with out any lock.
> Please correct me if I'm wrong.

These drivers have a clean and separate start_xmit() and xmit_completion
path, each one being correctly serialized. No extra lock needed.

In the case of r8169, we are still trying to get the driver in a clean
state (without races).

Then, we'll add BQL, and it will be as easy as other drivers.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html