lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Dec 2011 16:27:14 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: davem@...emloft.net Cc: netdev@...r.kernel.org Subject: re: ipv4: Perform peer validation on cached route lookup. Hello David S. Miller, This is a semi-automatic email about new static checker warnings. The patch efbc368dcc64: "ipv4: Perform peer validation on cached route lookup." from Dec 1, 2011, leads to the following Smatch complaint: net/ipv4/route.c +2369 ip_route_input_common() error: we previously assumed 'rth' could be null (see line 2378) net/ipv4/route.c 2368 for (rth = rcu_dereference(rt_hash_table[hash].chain); rth; 2369 rth = rcu_dereference(rth->dst.rt_next)) { ^^^^^^^^^^^^^^^^ The dereference here will oops 2370 if ((((__force u32)rth->rt_key_dst ^ (__force u32)daddr) | 2371 ((__force u32)rth->rt_key_src ^ (__force u32)saddr) | 2372 (rth->rt_route_iif ^ iif) | 2373 (rth->rt_key_tos ^ tos)) == 0 && 2374 rth->rt_mark == skb->mark && 2375 net_eq(dev_net(rth->dst.dev), net) && 2376 !rt_is_expired(rth)) { 2377 rth = ipv4_validate_peer(rth); 2378 if (!rth) 2379 continue; if we hit this new continue statement. 2380 if (noref) { regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists