netdev - Re: [RFC 2/3] if_ether.h: Add IEEE 802.1 Local Experimental Ethertype 1.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 Dec 2011 15:03:17 +0100
From:	Rémi Denis-Courmont <remi@...lab.net>
To:	Sjur Brændeland <sjurbren@...il.com>
Cc:	<netdev@...r.kernel.org>,
	Alexey Orishko <alexey.orishko@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC 2/3] if_ether.h: Add IEEE 802.1 Local Experimental Ethertype 1.

On Mon, 5 Dec 2011 14:14:30 +0100, Sjur Brændeland <sjurbren@...il.com>
wrote:
>> I don't think you can just go and steal a reserved EtherType. What if
>> some user-space (using packet sockets) or out-of-tree kernel driver
>> does actual "experiment" with this type?
> 
> I don't think defining this type in if_ether.h would harm anyone ;-)
> 
> I think your comments are applicable for the patch:
> "caif: Add support for CAIF over CDC NCM USB interface".

That patch makes no sense without this patch. I comment on the first patch
in the series that exhibits the problem.

> Currently CAIF over CDC NCM USB is only deployed for the Ethernet link
> between Host and Modem internally in a Smart Phone, and not out of the
> Smart Phone (Tethering). The modem's Ethernet interface is connected to
> the CAIF stack and not to the modem's IP stack.On the Linux Host,
> CAIF takes this EthType into use *only* for a Ethernet interface with
> the VID/PID of a ST-E CAIF modem.

It's even weirder then. If you have control over both ends and the NCM 1.0
interface is not adequate, then you really should use your own CDC class
for the purpose.

-- 
Rémi Denis-Courmont
http://www.remlab.net/

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html