netdev - Re: [PATCH] net/fec: fix the use of pdev->id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 07 Dec 2011 13:38:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shawn.guo@...aro.org
Cc:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] net/fec: fix the use of pdev->id

From: Shawn Guo <shawn.guo@...aro.org>
Date: Mon,  5 Dec 2011 23:01:15 +0800

> The pdev->id is used in several places for different purpose.  All
> these uses assume it's always the id of fec device which is >= 0.
> However this is only true for non-DT case.  When DT plays, pdev->id
> is always -1, which will break these pdev->id users.
> 
> Instead of fixing all these users one by one, this patch introduces
> a new member 'dev_id' to 'struct fec_enet_private' for holding the
> correct fec device id, and replaces all the existing uses of pdev->id
> with this dev_id.
> 
> Signed-off-by: Shawn Guo <shawn.guo@...aro.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html