netdev - RE: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 11 Dec 2011 05:47:55 -0800
From:	"Barak Witkowski" <barak@...adcom.com>
To:	"Michael Chan" <mchan@...adcom.com>,
	"'Joe Perches'" <joe@...ches.com>
cc:	"'davem@...emloft.net'" <davem@...emloft.net>,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	"Eilon Greenstein" <eilong@...adcom.com>
Subject: RE: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV_INFO upon
 FW request

Michael Chan wrote:
> Joe Perches wrote:
> >
> > > +	#define DRV_FLAGS_CAPABILITIES_LOADED_L2        0x00000002
> > > +	#define DRV_FLAGS_CAPABILITIES_LOADED_FCOE      0x00000004
> > > +	#define DRV_FLAGS_CAPABILITIES_LOADED_ISCSI     0x00000008
> >
> > I think the #defines should be left aligned.
> >
> 
> I'll fix up some of these, but many #defines in this file are not
> starting at the left margin.   Eilon will fix those up with a separate
> patch later.

In that area of the file all of the #defines related to specific field are not left aligned, but aligned to the field definition they refer to.
We looked into it and tried left aligning all of those definitions and found it less readable, as this part contains only structure definitions with specific #defines per each field, and some of those definitions include double hierarchy (which will be lost if they will all be left aligned).