netdev - Re: vmxnet3 driver broken since 3.0?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Dec 2011 23:54:50 -0800
From:	Alessandro Salvatori <sandr8@...il.com>
To:	Zbigniew Luszpinski <zbiggy@...pl>
Cc:	netdev@...r.kernel.org
Subject: Re: vmxnet3 driver broken since 3.0?

I guess this is the change that was introduced in 3.0 and that breaks vmxnet3:

commit 55513fb4281464e97aa1ff2b9c906ca5aed917c5
Author: Tom Herbert <therbert@...gle.com>
Date:   Mon Oct 18 17:55:58 2010 +0000

    net: fail alloc_netdev_mq if queue count < 1

    In alloc_netdev_mq fail if requested queue_count < 1.

    Signed-off-by: Tom Herbert <therbert@...gle.com>
    Acked-by: Eric Dumazet <eric.dumazet@...il.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/core/dev.c b/net/core/dev.c
index 04972a4..f44d29a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5511,6 +5511,12 @@ struct net_device *alloc_netdev_mq(int
sizeof_priv, const char *name,

        BUG_ON(strlen(name) >= sizeof(dev->name));

+       if (queue_count < 1) {
+               pr_err("alloc_netdev: Unable to allocate device "
+                      "with zero queues.\n");
+               return NULL;
+       }
+
        alloc_size = sizeof(struct net_device);
        if (sizeof_priv) {
                /* ensure 32-byte alignment of private area */

thanks!
-Alessandro-
 Here i am, A young man,
 A crashing computer program,
 Here is a pen, write out my name...

(from: The Servant - Orchestra)



On Sun, Dec 11, 2011 at 14:38, Zbigniew Luszpinski <zbiggy@...pl> wrote:
> Alessandro Salvatori <sandr8 <at> gmail.com> writes:
>> haven't had a chance to try the one from the 3.2 release candidates yet.
>
> In 3.2-rc5 is still broken. Exactly the same error you get. :(
> Someone introduced a change since kernel 3.0 which broke vmxnet3 driver. And
> this breaking change continues in kernel 3.1 and 3.2-rc5 so it seems it will not
> go away. :(
>
> have a nice day,
> Zbigniew Luszpinski
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html