netdev - [PATCH] rtnetlink: rtnl_link_register always returns zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 00:31:21 +0400
From:	alex.bluesman.smirnov@...il.com
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net,
	Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Subject: [PATCH] rtnetlink: rtnl_link_register always returns zero

From: Alexander Smirnov <alexander@...ovo.(none)>

Both functions 'rtnl_link_register' and '__rtnl_link_register' always
return zero. So handling return status has no sense in several drivers.

Signed-off-by: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
---
 drivers/net/bonding/bond_main.c |    6 +-----
 drivers/net/can/dev.c           |    8 +-------
 drivers/net/tun.c               |    8 ++------
 3 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 25a44d9..f79bb97 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4921,9 +4921,7 @@ static int __init bonding_init(void)
 	if (res)
 		goto out;
 
-	res = rtnl_link_register(&bond_link_ops);
-	if (res)
-		goto err_link;
+	rtnl_link_register(&bond_link_ops);
 
 	bond_create_debugfs();
 
@@ -4939,10 +4937,8 @@ out:
 	return res;
 err:
 	rtnl_link_unregister(&bond_link_ops);
-err_link:
 	unregister_pernet_subsys(&bond_net_ops);
 	goto out;
-
 }
 
 static void __exit bonding_exit(void)
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index 120f1ab..e5b5daf 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -756,13 +756,7 @@ EXPORT_SYMBOL_GPL(unregister_candev);
 
 static __init int can_dev_init(void)
 {
-	int err;
-
-	err = rtnl_link_register(&can_link_ops);
-	if (!err)
-		printk(KERN_INFO MOD_DESC "\n");
-
-	return err;
+	return rtnl_link_register(&can_link_ops);
 }
 module_init(can_dev_init);
 
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 93c5d72..bb034b1 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1632,16 +1632,12 @@ static const struct ethtool_ops tun_ethtool_ops = {
 
 static int __init tun_init(void)
 {
-	int ret = 0;
+	int ret;
 
 	pr_info("%s, %s\n", DRV_DESCRIPTION, DRV_VERSION);
 	pr_info("%s\n", DRV_COPYRIGHT);
 
-	ret = rtnl_link_register(&tun_link_ops);
-	if (ret) {
-		pr_err("Can't register link_ops\n");
-		goto err_linkops;
-	}
+	rtnl_link_register(&tun_link_ops);
 
 	ret = misc_register(&tun_miscdev);
 	if (ret) {
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html