netdev - Re: [PATCH] ipv6: Check dest prefix length on original route not copied one in rt6_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 14 Dec 2011 08:16:02 +0800
From:	"Yan, Zheng" <zheng.z.yan@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6: Check dest prefix length on original route not
 copied one in rt6_alloc_cow().

On 12/14/2011 06:35 AM, David Miller wrote:
> 
> After commit 8e2ec639173f325977818c45011ee176ef2b11f6 ("ipv6: don't
> use inetpeer to store metrics for routes.") the test in rt6_alloc_cow()
> for setting the ANYCAST flag is now wrong.
> 
> 'rt' will always now have a plen of 128, because it is set explicitly
> to 128 by ip6_rt_copy.
> 
> So to restore the semantics of the test, check the destination prefix
> length of 'ort'.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
> 
> Committed to 'net'.
> 
>  net/ipv6/route.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 3399dd3..b582a0a 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -728,7 +728,7 @@ static struct rt6_info *rt6_alloc_cow(const struct rt6_info *ort,
>  		int attempts = !in_softirq();
>  
>  		if (!(rt->rt6i_flags&RTF_GATEWAY)) {
> -			if (rt->rt6i_dst.plen != 128 &&
> +			if (ort->rt6i_dst.plen != 128 &&
>  			    ipv6_addr_equal(&ort->rt6i_dst.addr, daddr))
>  				rt->rt6i_flags |= RTF_ANYCAST;
>  			ipv6_addr_copy(&rt->rt6i_gateway, daddr);

My fault, sorry!

Yan, Zheng

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html