lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Dec 2011 13:15:56 +0800 From: "ASIX Allan Email [office]" <allan@...x.com.tw> To: "'Grant Grundler'" <grundler@...omium.org>, "'Eugene'" <elubarsky@...il.com> Cc: <netdev@...r.kernel.org>, "'Freddy Xin'" <freddy@...x.com.tw>, ASIX Louis [蘇威陸] <louis@...x.com.tw> Subject: RE: drivers/net/usb/asix: bug in asix_get_wol Resend without attachment due to below email server error. ======== ----- The following addresses had permanent fatal errors ----- <grundler@...omium.org> (reason: 552-5.7.0 Our system detected an illegal attachment on your message. Please) <elubarsky@...il.com> (reason: 552-5.7.0 Our system detected an illegal attachment on your message. Please) --- Best regards, Allan Chou Technical Support Division ASIX Electronics Corporation TEL: 886-3-5799500 ext.228 FAX: 886-3-5799558 E-mail: allan@...x.com.tw http://www.asix.com.tw/ -----Original Message----- From: ASIX Allan Email [office] [mailto:allan@...x.com.tw] Sent: Friday, December 16, 2011 11:38 AM To: 'Grant Grundler'; 'Eugene' Cc: 'netdev@...r.kernel.org'; 'Freddy Xin'; ASIX Louis [蘇威陸] Subject: RE: drivers/net/usb/asix: bug in asix_get_wol Importance: High Dear Grant and Eugene, Please refer to the attached file and below statements to modify the asix_get_wol() routine and let us know if this suggestion can solve your issues or not? Thanks a lot. ================ static void asix_get_wol(struct net_device *net, struct ethtool_wolinfo *wolinfo) { struct usbnet *dev = netdev_priv(net); u8 opt; if (asix_read_cmd(dev, AX_CMD_READ_MONITOR_MODE, 0, 0, 1, &opt) < 0) { wolinfo->supported = 0; wolinfo->wolopts = 0; return; } wolinfo->supported = WAKE_PHY | WAKE_MAGIC; wolinfo->wolopts = 0; if (opt & AX_MONITOR_LINK) wolinfo->wolopts |= WAKE_PHY; if (opt & AX_MONITOR_MAGIC) wolinfo->wolopts |= WAKE_MAGIC; } --- Best regards, Allan Chou Technical Support Division ASIX Electronics Corporation TEL: 886-3-5799500 ext.228 FAX: 886-3-5799558 E-mail: allan@...x.com.tw http://www.asix.com.tw/ -----Original Message----- From: grundler@...gle.com [mailto:grundler@...gle.com] On Behalf Of Grant Grundler Sent: Friday, December 16, 2011 12:48 AM To: Eugene; Allan Chou Cc: netdev@...r.kernel.org; Freddy Xin Subject: Re: drivers/net/usb/asix: bug in asix_get_wol On Tue, Dec 13, 2011 at 5:03 AM, Eugene <elubarsky@...il.com> wrote: > Hi Grant, > > > The problem is that, as it's currently written, asix_get_wol always > returns that wake-on-lan is disabled. I think that was the intent. Allan, can you please confirm? thanks, grant > > > Cheers, > Eugene > > On 12 December 2011 10:29, Grant Grundler <grundler@...omium.org> wrote: >> [+freddy/allan @ ASIX] >> >> On Sat, Dec 10, 2011 at 5:02 PM, Eugene <elubarsky@...il.com> wrote: >>> Dear kernel devs, >>> >>> Thanks for the commit at >>> http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=4ad1438f025ed8d1e4e95a796ca7f0ad5a22c378, >>> It successfully stops my adapter from dying when wake-on-lan gets >>> enabled. >> >> Hi Eugene! >> thanks for the "it works!" report. >> >>> However, I've noticed that it has broken asix_get_wol - the >>> lines >>> >>> if (opt & AX_MONITOR_LINK) >>> wolinfo->wolopts |= WAKE_PHY; >>> if (opt & AX_MONITOR_MAGIC) >>> wolinfo->wolopts |= WAKE_MAGIC; >>> >>> have been accidentally removed. >> >> This wasn't by accident. This comment in the commit log perhaps >> doesn't explain sufficiently: >> | Remove MONITOR_MODE. In this mode, Received packets are not buffered when >> | the remote wakeup is enabled. >> >>> The vendor driver has them, and I've >>> successfully tested a kernel with these lines included. The change is >>> too small for me to bother sending in a properly formatted patch... >> >> "Too small"? No such thing. :) >> >> cheers, >> grant -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists