netdev - Allocation of small packets on Rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 20 Dec 2011 10:30:26 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	netdev@...r.kernel.org
Subject: Allocation of small packets on Rx

Hi folks !

For a driver that gets small packets "inline" in the rx descriptors, I
allocate the skb in the rx poll and copy the data to it.

Should I allocate an skb of the just the right size for the packet (+
eventual alignment) or is there any benefit to allocating all skb's the
same size ?

The max size of those "inline" packets is 256 bytes and the driver today
always allocate that. Does that "help" the allocator some way or should
I just allocate what is needed for each packet ?

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html