lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 18 Dec 2011 22:42:56 -0800 From: Joe Perches <joe@...ches.com> To: Rusty Russell <rusty@...tcorp.com.au> Cc: David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org, pawel.moll@....com, netdev@...r.kernel.org Subject: Re: [PATCH 14/15] module_param: make bool parameters really bool (net & drivers/net) On Mon, 2011-12-19 at 16:19 +1030, Rusty Russell wrote: > diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h [] > @@ -808,8 +808,8 @@ typedef enum { [] > +static bool coalesce[MAX_UNITS] = {1,1,1,1,1,1,1,1}; > +static bool dynamic_ipg[MAX_UNITS] = {0,0,0,0,0,0,0,0}; Perhaps these array initializations could/should be: static bool coalesce[MAX_UNITS] = { [0 ... MAX_UNITS - 1] = true }; static bool dynamic_irq[MAX_UNITS] = { [0 ... MAX_UNITS - 1] = false }; in a separate patch maybe. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists