netdev - Re: [PATCH 1/2] bna: Added flash sub-module and ethtool eeprom entry points.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Dec 2011 09:44:22 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	<kgudipat@...cade.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<adapter_linux_open_src_team@...cade.com>, <rmody@...cade.com>
Subject: Re: [PATCH 1/2] bna: Added flash sub-module and ethtool eeprom
 entry points.

On Thu, 2011-12-22 at 15:29 -0800, kgudipat@...cade.com wrote:
> From: Krishna Gudipati <kgudipat@...cade.com>
> 
> Change details:
> 	- The patch adds flash sub-module to the bna driver.
> 	- Added ethtool set_eeprom() and get_eeprom() entry points to
> 	  support flash partition read/write operations.
[...]

I'm not going to say this is wrong, but we didn't find the EEPROM
operations suitable for firmware upgrade.  I have a couple of questions:

1. How long can a single set_eeprom() operation take?
2. Have you considered implementing the flash_device() operation or an
MTD driver?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html