netdev - Re: [PATCH net-next 2/2] net_sched: sfq: always randomize hash perturbation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Jan 2012 14:13:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net_sched: sfq: always randomize hash
 perturbation

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 04 Jan 2012 17:23:01 +0100

> SFQ q->perturbation is used in sfq_hash() as an input to Jenkins hash.
> 
> We currently randomize this 32bit value only if a perturbation timer is
> setup.
> 
> Its much better to always initialize it to defeat attackers, or else
> they can predict very well what kind of packets they have to forge to
> hit a particular flow.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html