netdev - Re: [PATCH 1/1] netfilter: Add possibility to turn off netfilters defrag per netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 08:19:19 +0100
From:	Hans Schillstrom <hans.schillstrom@...csson.com>
To:	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>
CC:	Hans Schillstrom <hans@...illstrom.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	Jan Engelhardt <jengelh@...ozas.de>,
	Patrick McHardy <kaber@...sh.net>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] netfilter: Add possibility to turn off netfilters defrag per netns

On Wednesday 04 January 2012 22:40:09 Jozsef Kadlecsik wrote:
> On Wed, 4 Jan 2012, Hans Schillstrom wrote:
> 
> > On Wednesday, January 04, 2012 19:05:10 Jozsef Kadlecsik wrote:
> > > On Wed, 4 Jan 2012, Pablo Neira Ayuso wrote:
> > > 
> > > > On Wed, Jan 04, 2012 at 12:48:35PM +0100, Hans Schillstrom wrote:
> > > > > I like that idea, an "early" table at prio -500 with PREROUTING.
> > > > > There is also a need for a new flag "--allfrags"
> > > > > i.e. all fragments needs to be sorted out and sent to same dest for defrag.
> > > > > 
> > > > > ex.
> > > > > iptables -t early -A PREROUTING -i eth0 --allfrags -j NOTRACK
> > > > 
> > > > New tables add too much overhead. We have discussed this before with
> > > > Patrick.
> > > > 
> > > > Since this still remains specific to your needs, I think you can
> > > > remove nf_conntrack module in your setup.
> > > > 
> > > > I don't come with one sane setup that may want selectively defragment
> > > > some traffic yes and other not.
> > > > 
> > > > Am I missing anything else?
> > > 
> > > I agree. If you don't want defragmentation at all, then make sure you 
> > > don't load the nf_conntrack module directly/indirectly. Conntrack doesn't 
> > > work without defragmentation anyway.
> > 
> > We are using LXC and it's only in the container that holds the external 
> > interface that can't have defragmentation.
> > The problem is if it's loaded you have it in all namespaces :-(
> 
> Conntrack is per net namespaces. You may have one container with conntrack 
> enabled and another one without conntrack.

How do you disable conntrack per netns ?
I can't see how to do it except for NOTRACK
Then the nf_defrag issue is still there...

> 
> Moreover, if you may receive fragments of the same packet at different 
> interfaces in different blades, then you may receive different whole 
> packets of the same flow at different interfaces/blades. But stateful 
> firewalling relies on the assumption that all packets goes through of the 
> firewall. 
True you can't have stateful fw in that stage because of fragments.
> Because it's not assured, conntrack may not run in the 
> containers you denoted as FW LXC.
Thats why I want to disable defrag and conntrack in them

A single flow, with Containers in any Blade.

    +---------------------------+    /              +--------------------+
--> | FW (no CT)frag  HMARK sel |--->---            | Conntrack and IPVS |---->
    +---------------------------+    \              +--------------------+
            \ (fragments)                                  ..
             v 
         +---------------------------+   /                 ..
         |     de-frag  HMARK sel    |----->  
         +---------------------------+   \          +--------------------+
                                                    | Conntrack and IPVS |---->
                                                    +--------------------+

Note that HMARK makes a preselection of which IPVS to use, and directs the flow
to the same IPVS independent of which Blade/interface it arrives on.
i.e. the defrag:ed packed will reach the same IPVS as the others.
                          
-- 
Regards
Hans Schillstrom <hans.schillstrom@...csson.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html