netdev - Re: asix, setting MAC broken in v3.2. Bisected to "NET: fix phy init for AX88772 USB ethernet".

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 08 Jan 2012 17:18:02 +0200
From:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
To:	Grant Grundler <grundler@...omium.org>
Cc:	netdev@...r.kernel.org, Freddy Xin <freddy@...x.com.tw>,
	Olof Johansson <olofj@...omium.org>,
	"David S. Miller" <davem@...emloft.net>,
	David Hollis <dhollis@...ehollis.com>,
	Allan Chou <allan@...x.com.tw>
Subject: Re: asix, setting MAC broken in v3.2. Bisected to "NET: fix phy
 init for AX88772 USB ethernet".

Quoting Grant Grundler <grundler@...omium.org>:

> On Fri, Jan 6, 2012 at 3:10 AM, Jussi Kivilinna
> <jussi.kivilinna@...et.fi> wrote:
>> Hello,
>>
>> I have asix adapter plugged to mini-server
>
> Which Asix adapter do you have? (Vendor/model)

It's Wii Ethernet adapter,
Bus 001 Device 008: ID 0b95:7720 ASIX Electronics Corp. AX88772

>
> Can you please provide:
> 1) dmesg output from asix driver
> 2) lsusb output for the device

Both attached.

>> and have to change MAC address
>> before DHCP because of ISP. This worked fine, until v3.2. Now I have to set
>> interface in promisc mode to have custom MAC working.
>
> Sorry - I didn't test this but I also would not expect this to break
> with the changes in 3.2.
>
> I'll see if Freddy or Allan (ASIX) need my help with this.

I found out that setting MAC in ax88722_reset() solves the issue for  
me. Maybe changes to init/reset sequence causes hardware to be reseted  
after set_mac_address call and revert to default MAC?

Patch attached.

-Jussi


View attachment "dmesg.txt" of type "text/plain" (52863 bytes)

View attachment "lsusb.txt" of type "text/plain" (2745 bytes)

View attachment "set-mac-address-in-ax88772_link_reset.patch" of type "text/x-patch" (1039 bytes)