netdev - Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Jan 2012 16:26:36 -0500
From:	Andy Gospodarek <gospo@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	maxim.uvarov@...cle.com, netdev@...r.kernel.org, fubar@...ibm.com,
	andy@...yhouse.net, amwang@...hat.com
Subject: Re: [PATCHv2] bond_alb: don't disable softirq under bond_alb_xmit

On Wed, Jan 11, 2012 at 12:52:46PM -0800, David Miller wrote:
> From: Maxim Uvarov <maxim.uvarov@...cle.com>
> Date: Mon,  9 Jan 2012 14:01:37 -0800
> 
> > No need to lock soft irqs under bond_alb_xmit()
> > which already has softirq disabled.
> > 
> > Changes:
> > 1. add non-bh/bh version to tlb_clear_slave()
> > 
> > 2. represent BH and non BH hash table locks
> > _lock_rx_hashtbl_bh/_unlock_rx_hashtbl_bh
> > _lock_rx_hashtbl/_unlock_rx_hashtbl
> > _lock_tx_hashtbl_bh/_unlock_tx_hashtbl_bh
> > _lock_tx_hashtbl/_unlock_tx_hashtbl
> > 
> > Signed-off-by: Maxim Uvarov <maxim.uvarov@...cle.com>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> Applied, thanks.

Thanks, Dave.  I'm still testing, but everything looks good so far.  I
ran into an issue with my test system and it took longer to get going
than I expected.  I should be done later tonight and will post if I find
anything wrong.

It's probably too late, but you can feel free to add a

Signed-off-by: Andy Gospodarek <andy@...yhouse.net>

if you want.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html