lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Jan 2012 15:25:32 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Štefan Gula <steweg@...il.com> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>, "David S. Miller" <davem@...emloft.net>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [patch v1, kernel version 3.2.1] net/ipv4/ip_gre: Ethernet multipoint GRE over IP Le lundi 16 janvier 2012 à 15:05 +0100, Štefan Gula a écrit : > Dňa 16. januára 2012 14:19, Eric Dumazet <eric.dumazet@...il.com> napísal/a: > > Unfortunately you call ipgre_tap_bridge_get() from > > ipgre_tap_bridge_get_raddr() but you dont release the refcount on > > use_count. Leak in ipgre_tunnel_xmit() > > > > > >> +__be32 ipgre_tap_bridge_get_raddr(struct ip_tunnel *tunnel, > >> + const unsigned char *addr) > >> +{ > >> + struct ipgre_tap_bridge_entry *entry; > >> + entry = ipgre_tap_bridge_get(tunnel, addr); > > > > So maybe you want __ipgre_tap_bridge_get(tunnel, addr); here ? > > > Hmmm.. I am sorry, I am maybe not that expert on C coding, as most of > the codes were copied from linux bridge code. Can you give me a hint > how should I change that? I dont see in net/bridge the code you copied. Could you give more information ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists