netdev - Re: [PATCH] bonding: fix enslaving in alb mode when link down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Jan 2012 21:00:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	jbohac@...e.cz, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: fix enslaving in alb mode when link down

From: Jay Vosburgh <fubar@...ibm.com>
Date: Wed, 18 Jan 2012 17:45:21 -0800

> Jiri Bohac <jbohac@...e.cz> wrote:
> 
>>bond_alb_init_slave() is called from bond_enslave() and sets the slave's MAC
>>address. This is done differently for TLB and ALB modes.
>>bond->alb_info.rlb_enabled is used to discriminate between the two modes but
>>this flag may be uninitialized if the slave is being enslaved prior to calling
>>bond_open() -> bond_alb_initialize() on the master.
>>
>>It turns out all the callers of alb_set_slave_mac_addr() pass
>>bond->alb_info.rlb_enabled as the hw parameter.
>>
>>This patch cleans up the unnecessary parameter of alb_set_slave_mac_addr() and
>>makes the function decide based on the bonding mode instead, which fixes the
>>above problem.
>>
>>Signed-off-by: Jiri Bohac <jbohac@...e.cz>
> 
> 	Looks reasonable.
> 
> 	-J
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied and queued up for -stable, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html