lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jan 2012 15:11:19 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: Stefan Gula <steweg@...t.sk> Cc: Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [patch v1, kernel version 3.2.1] Source mode for macvlan interaface Le lundi 23 janvier 2012 à 13:30 +0100, Stefan Gula a écrit : > From: Stefan Gula <steweg@...il.com> > > New mode of macvlan interface called "source" allows one to specify, > which frames are allowed to be received by given macvlan interface. > This logic is used only on received frames on underlaying interface. > The ability to send frames from macvlan interface through underlaying > interface is not modified. This feature allows one to simulate 802.1x > mac based VLAN bahaviour by using proper netlink message to configure > this behavior with utililty such as "ip link" from iproute2 suite. > > Signed-off-by: Stefan Gula <steweg@...il.com> Please limit line lengths to 70 chars. I dont understand your patch description at all, and reading its body I still dont understand its purpose. Is it sort of firewall rules (ebtable) or bridging code ? > +static void macvlan_hash_del_sources(struct macvlan_source_list *list, > + bool sync) > +{ > + hlist_del_rcu(&list->hlist); > + kfree_rcu(list, rcu); > + if (sync) > + synchronize_rcu(); > +} > + Please explain why are you using synchronize_rcu() here, as there must be a good reason, but I missed it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists